Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2774#discussion_r206215796
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
 ---
    @@ -357,9 +357,12 @@ private AllResources createClusterAllResources() {
                 ObjectResources rack = new ObjectResources(rackId);
                 racks.add(rack);
                 for (String nodeHost : nodeHosts) {
    -                for (RAS_Node node : hostnameToNodes(nodeHost)) {
    -                    
rack.availableResources.add(node.getTotalAvailableResources());
    -                    
rack.totalResources.add(node.getTotalAvailableResources());
    +                List<RAS_Node> nodes = hostnameToNodes(nodeHost);
    +                if(nodes != null) {
    --- End diff --
    
    nit: need a space after the `if`


---

Reply via email to