Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207325422
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void testMkFileFilterForLogCleanup() throws
IOException {
final long nowMillis = Time.currentTimeMillis();
final long cutoffMillis =
logCleaner.cleanupCutoffAgeMillis(nowMillis);
- final long oldMtimeMillis = cutoffMillis - 500;
- final long newMtimeMillis = cutoffMillis + 500;
+ final long interval = TimeUnit.MINUTES.toMillis(500);
--- End diff --
I don't think this change is necessary. The test is mocking some files for
right before and right after the cutoff. Why do we need to make it 500 minutes
before/after the cutoff instead of 500 milliseconds?
---
