Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2790#discussion_r207512766
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
 ---
    @@ -62,6 +62,7 @@
         private OutputCollector collector;
         private TupleToKafkaMapper<K,V> mapper;
         private KafkaTopicSelector topicSelector;
    +    private Callback providedCallback;
    --- End diff --
    
    Also I'm not sure exactly what someone implementing this interface would 
need, but maybe we should add a prepare method to the interface as well, so 
people who need some configuration or the topology context can get access? What 
do you think?


---

Reply via email to