Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2764#discussion_r208975129
  
    --- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java 
---
    @@ -39,6 +42,11 @@ public String getId() {
             return getNodeId() + ":" + getPort();
         }
     
    +    public List<Object> toList() {
    +        //For compatibility to call in Nimbus#mkAssignment
    --- End diff --
    
    Eh, it's probably fine. If you want to keep this method, I don't think the 
comment should be here though. It won't make sense outside the context of this 
PR. 


---

Reply via email to