Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2812#discussion_r212838119
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java
---
@@ -125,6 +129,12 @@ public long getRemoteVersion(ClientBlobStore store)
throws KeyNotFoundException,
@Override
public long fetchUnzipToTemp(ClientBlobStore store)
throws IOException, KeyNotFoundException, AuthorizationException {
+ synchronized (LocallyCachedTopologyBlob.class) {
+ if (!Files.exists(topologyBasicBlobsRootDir)) {
--- End diff --
If my understanding is right, your point looks like only valid when
there're multiple Supervisors running in a host with same base directory, and
IMHO it is not the thing that we support. Are there other cases we need to
handle with file lock?
---
