Github user agresch commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2854#discussion_r221626099
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
    @@ -2165,21 +2165,20 @@ public static String getWorkerDumpLink(String host, 
long port, String topologyId
          * @param client client
          * @param id id
          * @param hostPort hostPort
    -     * @param timeout timeout
    +     * @param timestamp timestamp
          * @param config config
          * @param profileAction profileAction
          * @throws TException TException
          */
         public static void getTopologyProfilingAction(
                 Nimbus.Iface client, String id,
    -            String hostPort, String timeout, Map<String,
    +            String hostPort, Long timestamp, Map<String,
    --- End diff --
    
    It's confusing to me the purpose of the timestamp.  What does 0 vs current 
time vs future time indicate?  


---

Reply via email to