Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224541248
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map<String,
Object> conf, BlobStore bl
out.close();
}
isSuccess = true;
+ } catch(FileNotFoundException fnf) {
+ LOG.warn("FileNotFoundException", fnf);
--- End diff --
It crashes the nimbus if the exception is propagated. (we have seen this
happening if topology gets killed while the non-leader nimbus tries to download
the blob). It may be better to swallow and let `downloadUpdatedBlob` return
false here?
---
