Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r226692517
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1041,6 +1041,19 @@
@isPositiveNumber
@NotNull
public static final String SUPERVISOR_WORKER_TIMEOUT_SECS =
"supervisor.worker.timeout.secs";
+
+ /**
+ * A map with blobstore keys mapped to each NUMA Node on the
supervisor that will be used
+ * by scheduler. CPUs, memory and ports available on each NUMA node
will be provided.
+ * Each supervisor will have different map of NUMAs.
+ * Example: "supervisor.numa.meta": { "Numas": [
+ * {"Id": 0, "MemoryInMB": 122880, "Cores": [ 0, 12, 1, 13, 2, 14, 3,
15, 4, 16, 5, 17],
+ * "Ports": [6700, 6701]},
+ * {"Id": 1, "MemoryInMB": 122880, "Cores": [ 6, 18, 7, 19, 8, 20, 9,
21, 10, 22, 11, 23],
+ * "Ports": [6702, 6703]}]}
+ */
+ public static final String SUPERVISOR_NUMA_META =
"supervisor.numa.meta";
--- End diff --
Could we do some verification of the config please. This is a complex
enough config that we would want to catch it being wrong early on.
Also as a nit: "Cores", "MemoryInMB", "Ports", and "Id" don't really follow
the naming convention that we have used with configs or maps elsewhere in the
code. We tend to use lowercase with '.' or '_' as separators instead of
CamelCase, but we are no where near consistent, so it is probably fine.
---
