Github user jacobtolar commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2878#discussion_r228237268
  
    --- Diff: storm-core/src/jvm/org/apache/storm/command/KillTopology.java ---
    @@ -25,21 +25,49 @@
     
         public static void main(String[] args) throws Exception {
             Map<String, Object> cl = CLI.opt("w", "wait", null, CLI.AS_INT)
    +                                    .boolOpt("i", "ignore-errors")
    --- End diff --
    
    I'm always a little wary of changing the default behavior of something. But 
I'd be happy to remove this option and just make this the default if that's 
acceptable. 


---

Reply via email to