Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233734291
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java
---
@@ -27,12 +27,15 @@
private final String consumerGroupId; // consumer group id for which
the offset needs to be calculated
private final String bootStrapBrokers; // bootstrap brokers
private final String securityProtocol; // security protocol to connect
to kafka
+ private final String consumerConfig; // security configuration file to
connect to secure kafka
--- End diff --
nit: IMHO we may be able to have better name (like securityConfFilePath?)
to represent what comment says. Other parameters look like self-described but I
couldn't imagine new parameter points to the file by its name.
---
