Ethanlm commented on a change in pull request #3104: [STORM-3484] Add Cluster
Blacklist to UI to show what supervisors are…
URL: https://github.com/apache/storm/pull/3104#discussion_r315408861
##########
File path: storm-client/src/storm.thrift
##########
@@ -759,6 +759,7 @@ service Nimbus {
void createStateInZookeeper(1: string key); // creates state in zookeeper
when blob is uploaded through command line
// need to add functions for asking about status of storms, what nodes
they're running on, looking at task logs
+ set<string> getBlacklistedSupervisorIds()
Review comment:
We don't need to expose this function to client. `getSupervisorSummary` and
`getSupervisorPageInfo` are the two places that needs this information. They
are all inside nimbus.java. We can just have a private
`getBlacklistedSupervisorIds` function in `nimbus.java` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
