Ethanlm commented on a change in pull request #3108: [STORM-3492] Add config to
prevent good supervisor with bad workers f…
URL: https://github.com/apache/storm/pull/3108#discussion_r316240526
##########
File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
##########
@@ -137,6 +137,14 @@
@IsImplementationOfClass(implementsClass = IBlacklistStrategy.class)
public static final String BLACKLIST_SCHEDULER_STRATEGY =
"blacklist.scheduler.strategy";
+ /**
+ * Whether the {@link
org.apache.storm.scheduler.blacklist.BlacklistScheduler} will put a
+ * (supervisor:slots) map to badSupervisorsToleranceSlidingWindow
Review comment:
This will be too concrete about the implementations and not easy for users
to understand. Maybe something like:
Whether {@link org.apache.storm.scheduler.blacklist.BlacklistScheduler}
will assume the supervisor is bad based on bad slots or not. When some slot is
bad, meaning the nimbus doesn't receive heartbeat from the worker in time, it's
hard to determine if it's because of the supervisor node or the worker itself
having issues. If this is set to true, the scheduler will simply assume the
supervisor is bad if there is any bad slot; otherwise, the scheduler will
simply assume it's not a supervisor problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
