srdo commented on a change in pull request #3101: STORM-1515: Fix LocalState
Corruption
URL: https://github.com/apache/storm/pull/3101#discussion_r319596676
##########
File path: storm-client/src/jvm/org/apache/storm/utils/LocalState.java
##########
@@ -123,6 +124,10 @@ private TBase deserialize(ThriftSerializedObject obj,
TDeserializer td) {
} catch (Exception e) {
attempts++;
if (attempts >= 10) {
+ if (e.getCause() instanceof TProtocolException) {
+ LOG.warn("LocalState file is corrupted, resetting
state");
Review comment:
Sorry just one more minor thing. Do you think it makes sense to have the
exception plus stack trace here as well? Otherwise it might be hard to debug if
this case is hit unexpectedly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
