Ethanlm commented on a change in pull request #3214: [MINOR] remove some unused
fields and correct comment typo
URL: https://github.com/apache/storm/pull/3214#discussion_r383349852
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/priority/TestFIFOSchedulingPriorityStrategy.java
##########
@@ -43,54 +43,52 @@
@Test
public void testFIFOEvictionStrategy() {
- try (Time.SimulatedTime sim = new Time.SimulatedTime()) {
Review comment:
We might not want to delete this because it simulates the Time and saves
time spending on unit test on some cases. It depends on if it has any effect on
this specific test. Make sure you understand it before you delete it. Or this
can be a separate PR in the future if it's still the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
