Ethanlm commented on a change in pull request #3237: STORM-3259: Adds NUMA awareness to enable worker pinning URL: https://github.com/apache/storm/pull/3237#discussion_r402617904
########## File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java ########## @@ -615,7 +616,7 @@ protected String javaCmd(String cmd) { * @throws IOException on any error. */ private List<String> mkLaunchCommand(final int memOnheap, final String stormRoot, - final String jlp) throws IOException { + final String jlp, final String numaId) throws IOException { Review comment: `numaId` not used anywhere? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services