Ethanlm commented on a change in pull request #3235: STORM-3605 add meter to
track scheduling timeouts
URL: https://github.com/apache/storm/pull/3235#discussion_r402628773
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/IScheduler.java
##########
@@ -13,10 +13,11 @@
package org.apache.storm.scheduler;
import java.util.Map;
+import org.apache.storm.metric.StormMetricsRegistry;
public interface IScheduler {
- void prepare(Map<String, Object> conf);
+ void prepare(Map<String, Object> conf, StormMetricsRegistry
metricsRegistry);
Review comment:
I guess changing public interface is fine since it's server side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
