Ethanlm commented on a change in pull request #3271:
URL: https://github.com/apache/storm/pull/3271#discussion_r426884017
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -2920,7 +2920,7 @@ private SupervisorSummary makeSupervisorSummary(String
supervisorId, SupervisorI
(int)
info.get_uptime_secs(), numPorts, numUsedPorts, supervisorId);
ret.set_total_resources(info.get_resources_map());
SupervisorResources resources =
nodeIdToResources.get().get(supervisorId);
- if (resources != null) {
+ if (resources != null && underlyingScheduler instanceof
ResourceAwareScheduler) {
Review comment:
What's the issue we want to solve here?
If it is just about skipping the code related to resources when the
scheduler is not resourceAware, then we have other places like
`getTopologyPageInfo` we need to take care of
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
