RuiLi8080 opened a new pull request #3289:
URL: https://github.com/apache/storm/pull/3289


   ## What is the purpose of the change
   
   This name is mainly used in two places:
   
   1. JCQueue metric name: Add unique executor id to metric name could be bad 
if we want to aggregate metrics across multiple executors/components. Also, 
executor id is already present in metrics dimension info such as 
`metricRegistry.gauge(queueName + "-capacity", cap, topologyId, componentId, 
taskId, port);`.
   
   2. JCQueue name: queue name was only used in debug level log in 
back-pressure usecase. It would be useful to know which executor is 
experiencing back-pressure when tuning topologies.
   In order to retain this info, we add a new field called `owner` of the 
JCQueue as we know it is only used in worker transfer queue or executor receive 
queue. Owner will just be the executor id or worker id.
   
   ## How was the change tested
   
   Tested with WordCount topology with LoggingMetricsConsumer. Executor id is 
removed from metric name. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to