RuiLi8080 commented on a change in pull request #3320:
URL: https://github.com/apache/storm/pull/3320#discussion_r465864721



##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java
##########
@@ -717,11 +718,19 @@ private Assignment getLocalAssignment(IStormClusterState 
stormClusterState, Stri
 
         IWaitStrategy backPressureWaitStrategy = 
IWaitStrategy.createBackPressureWaitStrategy(topologyConf);
         Map<List<Long>, JCQueue> receiveQueueMap = new HashMap<>();
+
         for (List<Long> executor : executors) {
             List<Integer> taskIds = StormCommon.executorIdToTasks(executor);
+            int taskId = taskIds.get(0);
+            String compId;
+            if (taskId == Constants.SYSTEM_TASK_ID) {
+                compId = Constants.SYSTEM_COMPONENT_ID;

Review comment:
       StormCommon.stormTaskInfoImpl() address taskID starting from 1. 
   WorkerState.readWorkerExecutors() additionally add 
Constants.SYSTEM_EXECUTOR_ID (-1) before reading from assignment. This system 
executor is not present in `taskToComponent` map.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to