agresch commented on a change in pull request #3307:
URL: https://github.com/apache/storm/pull/3307#discussion_r467273478
##########
File path: storm-client/src/jvm/org/apache/storm/metrics2/WindowedMeter.java
##########
@@ -76,65 +66,47 @@ public CountStatAndMetric(int numBuckets) {
odBuckets = new long[numBuckets];
odTime = new long[numBuckets];
allTime = 0;
- exactExtra = 0;
- bucketStart = startTime >= 0 ? startTime : System.currentTimeMillis();
+ bucketStart = Time.currentTimeMillis();
currentBucket = new AtomicLong(0);
- if (startTime < 0) {
- task = new Fresher();
- MetricStatTimer.timer.scheduleAtFixedRate(task, tmSize, tmSize);
- } else {
- task = null;
Review comment:
I believe the null task and negative start time were specific to unit
tests. I thought that seemed unnecessary, but I can add this back if you
prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
