agresch commented on a change in pull request #3317:
URL: https://github.com/apache/storm/pull/3317#discussion_r468877142
##########
File path: storm-client/src/jvm/org/apache/storm/messaging/IContext.java
##########
@@ -29,8 +30,11 @@
* This method is invoked at the startup of messaging plugin.
*
* @param topoConf storm configuration
+ * @param metricRegistry metric registry
+ * @param topologyId topology Id
+ * @param workerPort worker port
*/
- void prepare(Map<String, Object> topoConf);
+ void prepare(Map<String, Object> topoConf, StormMetricRegistry
metricRegistry, String topologyId, int workerPort);
Review comment:
Possibly we could add a new prepare that supports the V2 metrics and
keep this prepare (without metric support) and deprecate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
