[GitHub] [storm] vitaliyf commented on a change in pull request #3339: [STORM-3704] - Cosmetic: fix table header alignment in "Topology summary" table.

[GitBox]

vitaliyf commented on a change in pull request #3339:
URL: https://github.com/apache/storm/pull/3339#discussion_r498474874



##########
File path: 
storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/topology-page-template.html
##########
@@ -74,12 +74,12 @@
             Assigned CPU (%)
           </span>
         </th>
-        {{/schedulerDisplayResource}}
         <th>
           <span data-toggle="tooltip" data-placement="top" title="Assigned 
Generic Rescources by Scheduler.">
             Assigned Generic Resources
           </span>
         </th>
+        {{/schedulerDisplayResource}}

Review comment:
       This makes table headers match the logic on lines ~ 112-115: 
https://github.com/apache/storm/blob/8a00852f4b21797289eefa8c0b58b0e671990b6b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/topology-page-template.html#L112-L115




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org