bipinprasad commented on a change in pull request #3362:
URL: https://github.com/apache/storm/pull/3362#discussion_r543518075
##########
File path:
storm-server/src/test/java/org/apache/storm/utils/ServerUtilsTest.java
##########
@@ -272,18 +290,28 @@ public void
testIsAnyPosixProcessPidDirAliveMockingFileOwnerUid() throws Excepti
LOG.info("Test testIsAnyPosixProcessPidDirAlive is designed to run
on systems with /proc directory only, marking as success");
return;
}
- Collection<Long> pids = getRunningProcessIds();
- assertFalse(pids.isEmpty());
+ Collection<Long> allPids = getRunningProcessIds(null);
Review comment:
This tests the case where some (but not all) PIDs have been reassigned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]