Ethanlm edited a comment on pull request #3366: URL: https://github.com/apache/storm/pull/3366#issuecomment-882596986
Addressed most of the comments, except 1) add more comments in docker-to-squash.py. 2) add error messages in c code where it is missing 3) 4 unanswered questions about oci c code (mostly adopted from Hadoop's implementation) https://github.com/apache/storm/pull/3366#discussion_r550554308 https://github.com/apache/storm/pull/3366#discussion_r550557309 https://github.com/apache/storm/pull/3366#discussion_r549507997 https://github.com/apache/storm/pull/3366#discussion_r549506181 Will address these as follow-ups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org