Ethanlm commented on a change in pull request #3409:
URL: https://github.com/apache/storm/pull/3409#discussion_r690427094
##########
File path: docs/Metrics.md
##########
@@ -235,7 +235,7 @@ These queues report the following metrics:
`arrival_rate_secs` is an estimation of the number of tuples that are inserted
into the queue in one second, although it is actually the dequeue rate.
The `sojourn_time_ms` is calculated from the arrival rate and is an estimate
of how many milliseconds each tuple sits in the queue before it is processed.
-The queue has a set maximum number of entries. If the regular queue fills up
an overflow queue takes over. The number of tuple batches stored in this
overflow section are represented by the `overflow` metric. Storm also does
some micro batching of tuples for performance/efficiency reasons so you may see
the overflow with a very small number in it even if the queue is not full.
+The queue has a set maximum number of entries. If the regular queue fills up
an overflow queue takes over. The number of tuple batches stored in this
overflow section are represented by the `overflow` metric.
Review comment:
Remove `batches` in `tuple batches` too? If I understand correctly,
tuples are inserted to the queue one by one.
Maybe add the following:
Note that an overflow queue is only used for executors to receive tuples
from remote workers. It doesn't apply to intra-worker tuple transfer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
