Ethanlm commented on a change in pull request #3422:
URL: https://github.com/apache/storm/pull/3422#discussion_r741228782
##########
File path:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -335,13 +335,7 @@ void updateBlobs() {
f.get();
} catch (Exception e) {
updateBlobExceptions.mark();
- if
(Utils.exceptionCauseIsInstanceOf(TTransportException.class, e)) {
- LOG.warn("Network error while updating blobs, will
retry again later", e);
- } else if
(Utils.exceptionCauseIsInstanceOf(NimbusLeaderNotFoundException.class, e)) {
- LOG.warn("Nimbus unavailable to update blobs, will
retry again later", e);
- } else {
- LOG.warn("Could not update blob, will retry again
later", e);
- }
+ LOG.warn("Could not update blob ({}), will retry again
later." , e.getClass().getName());
Review comment:
This doesn't seem to log the stack trace. Is this desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
