bipinprasad commented on a change in pull request #3421:
URL: https://github.com/apache/storm/pull/3421#discussion_r741487990
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3907,6 +3938,12 @@ public void deleteBlob(String key) throws
AuthorizationException, KeyNotFoundExc
throw new WrappedIllegalStateException(message);
}
}
+ String topoId = topologyUsingThisBlob(stormClusterState,
topoCache, key);
+ if (null != topoId) {
Review comment:
In terms of style null == something or null != something seems dated to
when these mistakes (a = null) instead of (a == null) would not get caught by
IDE's. But it is harder to read, not necessary anymore, and counter to style
elsewhere in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
