agresch commented on pull request #3430: URL: https://github.com/apache/storm/pull/3430#issuecomment-1005027275
Previous reviewers on other changes had preferred to just have a default in defaults.yaml or in the code, but not both. I prefer adding the default in code over the defaults.yaml here, as if a topology is running when a cluster is upgraded, they may not have the new defaults.yaml, causing exceptions when calling ObjectReader.getBoolean(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
