agresch commented on a change in pull request #3442:
URL: https://github.com/apache/storm/pull/3442#discussion_r812323912
##########
File path: storm-client/test/py/test_storm_cli.py
##########
@@ -93,7 +93,7 @@ def test_localconfvalue_command(self):
self.base_test(
["storm", "localconfvalue", "conf_name"], self.mock_popen,
mock.call([
self.java_cmd, '-client', '-Dstorm.options=',
- '-Dstorm.conf.file=', '-cp', self.storm_dir + '/*:' +
self.storm_dir + '/lib:' + self.storm_dir +'/extlib:' + self.storm_dir +
'/extlib-daemon:' + self.storm_dir + '/conf',
+ '-Dstorm.conf.file=', '-cp', self.storm_dir + '/*:' +
self.storm_dir + '/lib/*:' + self.storm_dir +'/extlib:' + self.storm_dir +
'/extlib-daemon:' + self.storm_dir + '/conf',
Review comment:
what determines if a directory needs the * or not? Why not add it to
extlib and/or all directories?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
