bipinprasad commented on a change in pull request #3451:
URL: https://github.com/apache/storm/pull/3451#discussion_r821273471
##########
File path: LICENSE-binary
##########
@@ -645,6 +645,7 @@ The license texts of these dependencies can be found in the
licenses directory.
Apache License, Version 2.0
+ * reload4j (ch.qos.reload4j:reload4j:1.2.19 - https://reload4j.qos.ch)
Review comment:
A wildcard search “grep reload4j **/pom.xml” and in ~/.m2/repository
(grep reload4j **/\.pom), results in no hits. This project
https://github.com/qos-ch/reload4j/tree/master/src/main/java/org/apache/log4j
is documented as a drop in replacement for log4j version 1 and its classes.
In storm uses log4j2 as logging framework. It would seem that the already
included https://logging.apache.org/log4j/2.x/log4j-1.2-api/ is sufficient to
accommodate log4j-v1 calls.
https://www.slf4j.org/legacy.html
##########
File path: DEPENDENCY-LICENSES
##########
@@ -690,9 +690,9 @@ List of third-party dependencies grouped by their license
type.
* jnr-x86asm (com.github.jnr:jnr-x86asm:1.0.2 -
http://github.com/jnr/jnr-x86asm)
* Joni (org.jruby.joni:joni:2.1.11 -
http://nexus.sonatype.org/oss-repository-hosting.html/joni)
* JUL to SLF4J bridge (org.slf4j:jul-to-slf4j:1.7.26 -
http://www.slf4j.org)
- * SLF4J API Module (org.slf4j:slf4j-api:1.7.26 - http://www.slf4j.org)
+ * SLF4J API Module (org.slf4j:slf4j-api:1.7.36 - http://www.slf4j.org)
* SLF4J API Module (org.slf4j:slf4j-api:1.7.6 - http://www.slf4j.org)
- * SLF4J LOG4J-12 Binding (org.slf4j:slf4j-log4j12:1.7.26 -
http://www.slf4j.org)
+ * SLF4J Reload4j Binding (org.slf4j:slf4j-reload4j:1.7.36 -
http://reload4j.qos.ch)
Review comment:
My typo. Meant to say 1.7.36.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
