I downloaded the release artifacts and verified the PGP signatures and
checksums.
I then expanded the source tarball and built the project.
But first I applied following patch that disables testing with python2
because I could not easily install python2 at the time:
```diff
diff --git a/storm-client/pom.xml b/storm-client/pom.xml
index cc78ca2d3..13305d32e 100644
--- a/storm-client/pom.xml
+++ b/storm-client/pom.xml
@@ -271,25 +271,6 @@
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
- <execution>
- <configuration>
- <executable>python2.7</executable>
-
<workingDirectory>test/py</workingDirectory>
- <arguments>
- <argument>test_storm_cli.py</argument>
- </arguments>
- <environmentVariables>
-
<PYTHONPATH>../../../bin:$PYTHONPATH</PYTHONPATH>
-
<PYTHONDONTWRITEBYTECODE>true</PYTHONDONTWRITEBYTECODE>
- </environmentVariables>
- <skip>${skipTests}</skip>
- </configuration>
- <id>python2.7-test</id>
- <phase>test</phase>
- <goals>
- <goal>exec</goal>
- </goals>
- </execution>
<execution>
<configuration>
<executable>python3</executable>
```
My dependency versions were:
openjdk 1.8.0_332
maven 3.8.4
python 3.10
nodejs v17.7.2
ruby 3.0.3p157
My build commands were:
```
mvn clean
mvn install -pl storm-multilang/ruby -am
mvn install -pl storm-multilang/python -am
mvn install -pl storm-multilang/javascript -am
mvn install -pl storm-client -am
mvn install
```
Unit tests passed.
I unpacked the resulting tarball and ran WordCountTopology and checked
that it was doing work in the UI, and opened the logviewer for a worker.
I deactivated the topoligy via the CLI and rebalance and killed the
topology via the UI.
All seems to work.
+1
Issues Encountered:
0.
There are two spurious files ending in .asc.asc that appear to be invalid and
should probably be removed from the dist site:
https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/apache-storm-2.4.0.tar.gz.asc.asc
https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/apache-storm-2.4.0.zip.asc.asc
The source tarball contents match the git repo at
https://github.com/apache/storm/commit/a432e99bca526886655cc1d5b2453a09b302b5ca,
however the source tarball contains several extra files. Most are
'dependency-reduced-pom.xml' files that are build artifacts, and two
other (/storm-core/null and /storm-server/csvmetrics) seem to be test
artifacts. If these are intentionally included in the source
distribution, then disregard.
The following issues could be addressed to help make evaluation of storm
releases more efficient:
1. Builds failed with JDK17, and the WordCount topology could not be run
with JDK11. It would be good to document supported versions of Java and
how to address incompatibilities. (For example, how to adjust the
default worker GC options when using JDK11.)
2. Python 2 reached end-of-life over two years ago. Perhaps we should
drop support for it and remove the test dependency. We do not need to
deliberately break support, but let's not require it for building and
testing the project.
https://www.python.org/doc/sunset-python-2/
3. The build cannot be completed with the latest version of maven. We
should fix this to work or document which versions of maven are
supported.
4. The build instructions in the DEVELOPER.md document are `mvn clean
install`, and this did not work with a fresh Maven repository. Probably
we should update the build steps or adjust the code so that this works
once again.
5. I noticed that worker logs are HTML-escaping program output, but then
the worker logs are rendered in preformatted text blocks. This may not
be what users expect.
Regards,
--
Derek
On Wed, Mar 16, 2022 at 07:19:35AM -0700, Bipin Prasad wrote:
> Gentle reminder to vote on this release for Storm 2.4.0 (rc2):
>
> "How to vote" is described here:
> https://github.com/apache/storm/blob/master/RELEASING.md#how-to-vote-on-a-release-candidate
>
> *This is a call to vote on releasing Apache Storm 2.4.0 (rc2)*
>
> Full list of changes in this release:
>
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/RELEASE_NOTES.html
>
> The tag/commit to be voted upon is v2.4.0:
>
> https://github.com/apache/storm/commit/a432e99bca526886655cc1d5b2453a09b302b5ca
>
>
> The source archive being voted upon can be found here:
>
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/apache-storm-2.4.0-src.tar.gz
>
> Other release files, signatures and digests can be found here:
>
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/
>
> The release artifacts are signed with the following key:
>
> https://keyserver.ubuntu.com/pks/lookup?op=index&fingerprint=on&search=0x51379DA8A7AE5B02674EF15C134716AF768D9B6E
> in this file
> https://www.apache.org/dist/storm/KEYS
>
> The Nexus staging repository for this release is:
>
> https://repository.apache.org/content/repositories/orgapachestorm-1103/
>
> Please vote on releasing this package as Apache Storm 2.4.0.
>
> When voting, please list the actions taken to verify the release.
>
> This vote will be open for at least 72 hours.
>
> [ ] +1 Release this package as Apache Storm 2.4.0
> [ ] 0 No opinion
> [ ] -1 Do not release this package because...
>
> Thanks to everyone who contributed to this release.
>
> On Thu, Mar 10, 2022 at 6:24 AM Bipin Prasad <[email protected]> wrote:
>
> > Corrected email
> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/
> > "How to vote" is described here:
> > https://github.com/apache/storm/blob/master/RELEASING.md#how-to-vote-on-a-release-candidate
> >
> > *This is a call to vote on releasing Apache Storm 2.4.0 (rc2)*
> >
> > Full list of changes in this release:
> >
> >
> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/RELEASE_NOTES.html
> >
> > The tag/commit to be voted upon is v2.4.0:
> >
> >
> > https://github.com/apache/storm/commit/a432e99bca526886655cc1d5b2453a09b302b5ca
> >
> >
> > The source archive being voted upon can be found here:
> >
> >
> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/apache-storm-2.4.0-src.tar.gz
> >
> > Other release files, signatures and digests can be found here:
> >
> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.4.0-rc2/
> >
> > The release artifacts are signed with the following key:
> >
> >
> > https://keyserver.ubuntu.com/pks/lookup?op=index&fingerprint=on&search=0x51379DA8A7AE5B02674EF15C134716AF768D9B6E
> > in this file
> > https://www.apache.org/dist/storm/KEYS
> >
> > The Nexus staging repository for this release is:
> >
> > https://repository.apache.org/content/repositories/orgapachestorm-1103/
> >
> > Please vote on releasing this package as Apache Storm 2.4.0.
> >
> > When voting, please list the actions taken to verify the release.
> >
> > This vote will be open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache Storm 2.4.0
> > [ ] 0 No opinion
> > [ ] -1 Do not release this package because...
> >
> > Thanks to everyone who contributed to this release.
> >
