snikhil5 commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924583718


##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##########
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
     public void beforeAll(ExtensionContext arg0) throws Exception {
         System.setProperty(TEST_BUILD_DATA, "target/test/data");
         hadoopConf = hadoopConfSupplier.get();
+        String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;

Review Comment:
   Yes it is related to junit. The getTestDir() in MiniDFSCluster class in 
Hadoop was using GenericTestUtils (which in turn uses Assert from junit4). This 
change gets around that by setting the temp dir here instead of relying on 
GenericTestUtils.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to