Okay thanks, so I guess I need to wait until next Tuesday to get this pull request to be merged, right ? Next naive question: who should click on "Merge Pull Request" here https://github.com/apache/storm-site/pull/45#pullrequestreview-1585813522 ?
Thank, Alexandre Le dim. 20 août 2023 à 09:10, Richard Zowalla <rich...@zowalla.com> a écrit : > > Wait for reviews + 2-3 days before merging (timezones, holidays, etc), so > people have a chance to look. > > In case of "storm-site": > > It uses "asf-site" branch and will automatically picked up by the ASF site > builder and gets published once a new commit is put to that branch ;-) > > Am 19. August 2023 22:04:07 MESZ schrieb Alexandre Vermeerbergen > <avermeerber...@gmail.com>: > >I just sent pull request https://github.com/apache/storm-site/pull/45 > >for this change to storm-site. > > > >Since it's my first pull request, I am curious: what is the next step > >to get this change merged, and then Apache Storm site to be actually > >updated? > > > >Note: I have tested my change on my machine using: > >bundle exec jekyll serve -w > >(as documented in storm-site/README.md) > > > >Also, I have includes in my pull request a simple change to > >.gitignore, so as to avoid Gemfile.lock file to be part of the > >repository (it's a transient file generated by the bundle XXX command) > > > >Kind regards, > >Alexandre > > > >Le ven. 18 août 2023 à 22:00, Alexandre Vermeerbergen > ><avermeerber...@gmail.com> a écrit : > >> > >> OK, created https://issues.apache.org/jira/browse/STORM-3957 for the > >> tracking (self assigned) > >> > >> Le ven. 18 août 2023 à 21:48, Richard Zowalla <r...@apache.org> a écrit : > >> > > >> > I am fine with it. > >> > > >> > It might be a nice to have to track website changes in Jira, imho. > >> > We won'T include such changes in a release's changelog but might be a > >> > good thing to know, that someone is working on that task. > >> > > >> > Gruß > >> > Richard > >> > > >> > Am Freitag, dem 18.08.2023 um 19:59 +0200 schrieb Alexandre > >> > Vermeerbergen: > >> > > Hello, > >> > > > >> > > Community/People page on storm-site > >> > > (https://storm.apache.org/contribute/People.html) is currently > >> > > outdated. > >> > > > >> > > For example, it is missing Julien Nioche who recently joined as a > >> > > PMC. > >> > > > >> > > I volunteer to fix this page, by replacing the static table fed by > >> > > _data/committers.yml file, by a link to ASF's > >> > > https://projects.apache.org/committee.html?storm > >> > > > >> > > My idea is to replace existing People.md file's content by this > >> > > content: > >> > > > >> > > --- > >> > > title: People > >> > > layout: documentation > >> > > documentation: true > >> > > --- > >> > > > >> > > Current list of committers and PMC's are > >> > > [here](https://projects.apache.org/committee.html?storm) > >> > > > >> > > > >> > > and to remove _data/committers.yml file. > >> > > > >> > > Any objection? > >> > > > >> > > Do I need to create a JIRA and then a branch prefixed by JIRA number, > >> > > like it's required for code changes ? > >> > > > >> > > Note: I am aware that there is the same issue with Project Leader & > >> > > Committers list at https://github.com/apache/storm#readme, but here I > >> > > am starting with storm-site. > >> > > > >> > > Kind regards, > >> > > Alexandre > >> >
