agresch commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1717132587
########## storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java: ########## @@ -12,11 +12,14 @@ package org.apache.storm.utils; +import static org.apache.storm.Config.NIMBUS_THRIFT_TLS_TRANSPORT_PLUGIN; Review Comment: I think the style prefers non static imports, but not sure. ########## storm-client/test/resources/ssl/README.md: ########## @@ -0,0 +1,10 @@ +SSL test data +=================== Review Comment: is this file used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
