reiabreu commented on issue #8019: URL: https://github.com/apache/storm/issues/8019#issuecomment-2766988945
Hello Jake, I haven't tested this myself, but looking at the original PR that introduced the change and the respective issue: - A new object was being created everytime metrics were requested, therefore resetting the values to zero before re-computing them: https://github.com/apache/storm/blob/fc0859e361c4c9ffc6733b4938cbcaf454fb2afb/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java#L77 - The new implementation is reusing the state that is in memory, which means that it's accumulating consecutive metrics' values: https://github.com/RuiLi8080/storm/blob/2622b176ceedac91100ff5523a5abda2f584444c/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics2/KafkaOffsetPartitionMetrics.java#L85 If confirmed, it's indeed a regression. Do you want to open a PR to fix it? I can probably pick it up over the next weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
