[
https://issues.apache.org/jira/browse/STORM-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983067#comment-13983067
]
ASF GitHub Bot commented on STORM-269:
--------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/91#issuecomment-41568308
@harshach, @ptgoetz OK, good to know it is not as open as I feared.
With the String compare instead of File compare, do we know whether this
will give a string with a trailing slash?
```
(.getCanonicalPath (File. root-dir))
```
If it does, we should be OK. If not, then a user could get to certain
sibling directories. (e.g., if `root-dir` was a directory named "foo", then a
user could read from a sibling directory "foobar").
> Any readable file exposed via UI log viewer
> -------------------------------------------
>
> Key: STORM-269
> URL: https://issues.apache.org/jira/browse/STORM-269
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Jared Kuolt
> Assignee: P. Taylor Goetz
> Labels: security
>
> Note: This is actually version 0.9.0.1 but I couldn't choose that in the
> dropdown. I suspect that the problem still exists.
> I found that it's possible to access any readable file on the system via the
> UI worker log viewer. To reproduce, navigate to:
> http://<host:port>/log?file=../../../../../../../../etc/passwd
--
This message was sent by Atlassian JIRA
(v6.2#6252)
