Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/254#discussion_r17392712
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -144,14 +145,30 @@ public EmitState next(SpoutOutputCollector collector)
{
}
}
+ /**
+ * Fetch the failed messages ready for retry. If there are no failed
messages, or none are ready for retry, then it
+ * returns an empty List (i.e., not null).
+ */
+ private SortedSet<Long> failedMsgsReadyForRetry() {
--- End diff --
I'm actually okay with the naming as is. I tend to favor reserving the
"get*" convention for methods that are strictly accessors and don't do any
calculation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
