sigee commented on code in PR #1612: URL: https://github.com/apache/stormcrawler/pull/1612#discussion_r2226246675
########## external/sql/src/main/java/org/apache/stormcrawler/sql/IndexerBolt.java: ########## Review Comment: To be honest, I do not really get why do you changed the single `StringBuilder query` to `StringBuilder fieldsBuilder`, `StringBuilder placeholdersBuilder` and `StringBuilder updatesBuilder` with the overcomplicated query building? One single for loop appends different parts to different StringBuilders. The original version was already a `PreparedStatement`. I can't see any additional value replacing it. Finally it is the same SQL query generated with more resource is used. Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
