jnioche commented on PR #1728:
URL: https://github.com/apache/stormcrawler/pull/1728#issuecomment-3556591050

    
   > I didn't really think about implementing it as a parse filter but as the 
process (text analysis by the NLP engine in Presidio) is quite consuming, I 
think it may be better to have this in a separate bolt to have better measures 
about tuple processing time/latency.
   
   I haven't looked at the details yet but I agree with @rzo1 that this feels 
like it should be a ParseFilter.
   
   We log [processing times in 
ParseFilters](https://github.com/apache/stormcrawler/blob/15b09c1a3b92d500146365ba2db7c39df97ffbc7/core/src/main/java/org/apache/stormcrawler/parse/ParseFilters.java#L146)
 but could extend that to send proper metrics


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to