On Mon, Oct 6, 2014 at 10:10 AM, Reka Thirunavukkarasu <[email protected]> wrote:
> Hi Udara, > > AFAIK, this is obsolete code segment as of what we are doing now.. > > @Martin/IsuruH/Udara > Shall we remove the code segment that we are not using from grouping > branch? Since we are having sonar integrated, it would be good to execute > sonar in our grouping branch too. If we remove the unused code, then it > will be easy to track the newly added code. > +1. This will help in to clean up the code. > > Thanks, > Reka > > On Mon, Oct 6, 2014 at 10:04 AM, Udara Liyanage <[email protected]> wrote: > >> Hi Martin, >> >> Noticed that key is hard coded in Topologybuilder.java for some reason or >> may be some testing purpose. Should n't this be messConfigApp.getAlias(). >> If so, I can make the change and commit. Could someone confirm whether it >> is done with purpose or not? >> >> 1. try { >> 2. >> 3. TopologyManager.acquireWriteLock(); >> 4. String key = "compositeApplicationAlias"; >> //app.getAlias() >> 5. topology.addConfigCompositeApplication(key, >> messConfigApp); >> 6. TopologyManager.updateTopology(topology); >> 7. } finally { >> 8. TopologyManager.releaseWriteLock(); >> 9. } >> >> >> >> >> Udara Liyanage >> Software Engineer >> WSO2, Inc.: http://wso2.com >> lean. enterprise. middleware >> >> web: http://udaraliyanage.wordpress.com >> phone: +94 71 443 6897 >> > > > > -- > Reka Thirunavukkarasu > Senior Software Engineer, > WSO2, Inc.:http://wso2.com, > Mobile: +94776442007 > > -- > <%2B94776442007> > Thanks and Regards, > > Isuru H. > <%2B94776442007> > +94 716 358 048 <%2B94776442007>* <http://wso2.com/>* > > > * <http://wso2.com/>* > > >
