Hi, IMO having a separate configuration file for just executor service is needed. We can have a common file as Imesh suggested where we can define other common parameters too.
On Mon, Dec 1, 2014 at 5:50 PM, Imesh Gunaratne <[email protected]> wrote: > +1 A good design Gayan! > > On Mon, Dec 1, 2014 at 12:39 PM, Gayan Gunarathne <[email protected]> wrote: > >> >> As for the $subject, we are identified following modifications. >> >> 1. We will maintain the map of executor services which returns the >> executor service per component. Once the component (eg CC,AS) needs to >> create a thread it should be getting his relevant executor service from >> the executor service map based on the identifier. >> > > There could be scenarios where we need multiple executor services per > component. > >> >> 2. We will maintain the executor service identifier and thread pool size >> in the configuration level.(Please note that we are thinking to use the >> fixed Thread Pool size executor services) >> >> As an example: >> <threadPool> >> <autoscaler> >> <identifier>AS-Listerner</identifier> >> <threadPoolSize>10</threadPoolSize> >> </autoscaler> >> </threadPool> >> >> I guess we can maintain these executor service related configuration in >> separate configuration file. WDYT? >> > >> > May be we could call this stratos.conf if we are looking for a common name. > > On Mon, Dec 1, 2014 at 12:39 PM, Gayan Gunarathne <[email protected]> wrote: > >> >> As for the $subject, we are identified following modifications. >> >> 1. We will maintain the map of executor services which returns the >> executor service per component. Once the component (eg CC,AS) needs to >> create a thread it should be getting his relevant executor service from >> the executor service map based on the identifier. >> >> 2. We will maintain the executor service identifier and thread pool size >> in the configuration level.(Please note that we are thinking to use the >> fixed Thread Pool size executor services) >> >> As an example: >> <threadPool> >> <autoscaler> >> <identifier>AS-Listerner</identifier> >> <threadPoolSize>10</threadPoolSize> >> </autoscaler> >> </threadPool> >> >> I guess we can maintain these executor service related configuration in >> separate configuration file. WDYT? >> >> Please share your thoughts on this. >> >> Thanks, >> Gayan >> >> >> >> > > > -- > Imesh Gunaratne > > Technical Lead, WSO2 > Committer & PMC Member, Apache Stratos > -- Udara Liyanage Software Engineer WSO2, Inc.: http://wso2.com lean. enterprise. middleware web: http://udaraliyanage.wordpress.com phone: +94 71 443 6897
