Hi, I've reworked the changes and pushed to remote. Please merge the PR[1].
[1] - https://github.com/apache/stratos/pull/160 Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Sun, Dec 21, 2014 at 7:07 PM, Chamila De Alwis <chami...@wso2.com> wrote: > Hi Raj, > > Sorry, I couldn't get online sooner. Doing the rework now. > > > Regards, > Chamila de Alwis > Software Engineer | WSO2 | +94772207163 > Blog: code.chamiladealwis.com > > > > On Sun, Dec 21, 2014 at 6:15 PM, Rajkumar Rajaratnam <rajkum...@wso2.com> > wrote: > >> Hi Chamila, >> >> I couldn't apply our patches because there were some major refactoring, >> hence conflicts. I have re-done my changes and attached here. Can you also >> re-do the changes to python agent and send PR? >> >> Once you send a PR, I can commit my changes and merge your changes. >> >> Thanks. >> >> On Sun, Dec 21, 2014 at 10:54 AM, Rajkumar Rajaratnam <rajkum...@wso2.com >> > wrote: >> >>> Hi, >>> >>> Please find the cartridge-agent patch implemented by Chamils for this >>> corresponding changes. >>> >>> Thanks. >>> >>> On Sat, Dec 13, 2014 at 9:37 PM, Rajkumar Rajaratnam <rajkum...@wso2.com >>> > wrote: >>> >>>> Hi, >>>> >>>> Did anyone get a chance to commit this changes? >>>> >>>> Thanks. >>>> >>>> On Fri, Dec 5, 2014 at 7:46 PM, Rajkumar Rajaratnam <rajkum...@wso2.com >>>> > wrote: >>>>> >>>>> Hi, >>>>> >>>>> I am attaching the patch for topology changes. >>>>> >>>>> @Chamila, >>>>> >>>>> Please do the changes in python agent accordingly. Basic idea is that >>>>> topology and topology events are carrying >>>>> >>>>> - list of private IPs >>>>> - list of public IPs >>>>> - a default public IP (for LB routing) >>>>> - a default private IP (for LB routing) >>>>> >>>>> Thanks. >>>>> >>>>> On Fri, Dec 5, 2014 at 10:59 AM, Reka Thirunavukkarasu <r...@wso2.com> >>>>> wrote: >>>>> >>>>>> HI Raj, >>>>>> >>>>>> On Fri, Dec 5, 2014 at 8:20 AM, Rajkumar Rajaratnam < >>>>>> rajkum...@wso2.com> wrote: >>>>>> >>>>>>> Okay. >>>>>>> >>>>>>> @Reka, Please let me know when are done with testing. >>>>>>> >>>>>> >>>>>> Sure..We are in the process of stabilising grouping feature in the >>>>>> master. Will update once we have the complete flow working fine.. >>>>>> >>>>>>> >>>>>>> I will make a diff in meantime. >>>>>>> >>>>>> >>>>>> +1. Anyway, you might need to rebase it when you apply it as we are >>>>>> also fixing bugs in the same code.. >>>>>> >>>>>> Thanks, >>>>>> Reka >>>>>> >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Fri, Dec 5, 2014 at 8:08 AM, Lakmal Warusawithana < >>>>>>> lak...@wso2.com> wrote: >>>>>>> >>>>>>>> Sure, shall we do this after complete full work flow test in >>>>>>>> grouping. >>>>>>>> >>>>>>>> On Fri, Dec 5, 2014 at 8:00 AM, Rajkumar Rajaratnam < >>>>>>>> rajkum...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please let me know the decision on this before code freeze. This >>>>>>>>> is a simple change to do. >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> On Fri, Dec 5, 2014 at 1:41 AM, Rajkumar Rajaratnam < >>>>>>>>> rajkum...@wso2.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Devs, >>>>>>>>>> >>>>>>>>>> I have integrated multiple network interfaces support into the >>>>>>>>>> master branch and it is working fine. >>>>>>>>>> >>>>>>>>>> Now we should modify the topology to include list of >>>>>>>>>> private/public IP addresses. Currently topology and topology events >>>>>>>>>> supports max of one public IP and one private IP. >>>>>>>>>> >>>>>>>>>> Can I go ahead and do this change? >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Rajkumar Rajaratnam >>>>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>>>> Software Engineer, WSO2 >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Rajkumar Rajaratnam >>>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>>> Software Engineer, WSO2 >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Lakmal Warusawithana >>>>>>>> Vice President, Apache Stratos >>>>>>>> Director - Cloud Architecture; WSO2 Inc. >>>>>>>> Mobile : +94714289692 >>>>>>>> Blog : http://lakmalsview.blogspot.com/ >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Rajkumar Rajaratnam >>>>>>> Committer & PMC Member, Apache Stratos >>>>>>> Software Engineer, WSO2 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Reka Thirunavukkarasu >>>>>> Senior Software Engineer, >>>>>> WSO2, Inc.:http://wso2.com, >>>>>> Mobile: +94776442007 >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Rajkumar Rajaratnam >>>>> Committer & PMC Member, Apache Stratos >>>>> Software Engineer, WSO2 >>>>> >>>> >>>> >>>> -- >>>> Rajkumar Rajaratnam >>>> Committer & PMC Member, Apache Stratos >>>> Software Engineer, WSO2 >>>> >>> >>> >>> >>> -- >>> Rajkumar Rajaratnam >>> Committer & PMC Member, Apache Stratos >>> Software Engineer, WSO2 >>> >>> Mobile : +94777568639 >>> Blog : rajkumarr.com >>> >> >> >> >> -- >> Rajkumar Rajaratnam >> Committer & PMC Member, Apache Stratos >> Software Engineer, WSO2 >> >> Mobile : +94777568639 >> Blog : rajkumarr.com >> > >
