Github user imesh commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/194#discussion_r23752039
  
    --- Diff: 
components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/services/impl/AutoscalerServiceImpl.java
 ---
    @@ -337,6 +337,28 @@ private void addApplicationSignUp(ApplicationContext 
applicationContext, String
             }
         }
     
    +    private void removeApplicationSignUp(ApplicationContext 
applicationContext){
    +        try {
    +            if (log.isInfoEnabled()) {
    +                log.info(String.format("Removing application signup: 
[application-id] %s",
    +                        applicationContext.getApplicationId()));
    +            }
    +
    +            StratosManagerServiceClient serviceClient = 
StratosManagerServiceClient.getInstance();
    +
    +            ApplicationSignUp applicationSignUp[] = 
serviceClient.getApplicationSignUps(applicationContext.getApplicationId());
    +            for(ApplicationSignUp appSignUp : applicationSignUp)
    +            {
    +                
serviceClient.removeApplicationSignUp(appSignUp.getApplicationId(), 
appSignUp.getTenantId());
    --- End diff --
    
    Since applicationSignUps is an array there could be null elements inside 
the array. Therefore better to check null for the element before invoking 
serviceClient.removeApplicationSignUp() method.
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to