Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/200#discussion_r23890488
--- Diff:
components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftClientConfig.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.stratos.common.statistics.publisher;
+
+
+/**
+ * Thrift Client configuration.
+ */
+public class ThriftClientConfig {
+
+ /**
+ * Setting the relative path to thrift-client-config.xml file
+ */
+ public static final String THRIFT_CLIENT_CONFIG_FILE_PATH =
"thrift.client.config.file.path";
+ private static final String THRIFT_CLIENT_CONFIG_FILE_NAME =
"thrift-client-config.xml";
+
+ // here "user.dir" has been used instead of "carbon.home"
+ // since "carbon.home" returned a null value in this instance
+ private static final String CARBON_HOME = "user.dir";
+
+ // Test configuration file path is used here
+ // Main configuration file path can be found under
"/products/stratos/conf/data-bridge/"
+ private static final String REPOSITORY_CONF =
"/components/org.apache.stratos.common/src/test/resources/";
--- End diff --
This is not a good practice. We need to handle this other way around. The
default should be carbon conf folder, the unit test need to set the system
property specifically.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
