Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/215#discussion_r24238660
--- Diff:
components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/registry/RegistryManager.java
---
@@ -118,19 +118,33 @@ private void persist(Object dataObj, String
resourcePath) throws AutoScalerExcep
}
public void persistAutoscalerPolicy(AutoscalePolicy autoscalePolicy) {
- String resourcePath = AutoscalerConstants.AUTOSCALER_RESOURCE +
AutoscalerConstants.AS_POLICY_RESOURCE + "/" + autoscalePolicy.getId();
- persist(autoscalePolicy, resourcePath);
- if (log.isDebugEnabled()) {
- log.debug(String.format("Autoscaler policy written to
registry: [id] %s [name] %s [description] %s",
- autoscalePolicy.getId(),
autoscalePolicy.getDisplayName(), autoscalePolicy.getDescription()));
+ try {
+ String resourcePath = AutoscalerConstants.AUTOSCALER_RESOURCE +
+ AutoscalerConstants.AS_POLICY_RESOURCE + "/" +
autoscalePolicy.getId();
+
+ persist(autoscalePolicy, resourcePath);
+ if (log.isDebugEnabled()) {
+ log.debug(String.format("Autoscaler policy written to
registry: [id] %s [name] %s [description] %s",
+ autoscalePolicy.getId(),
autoscalePolicy.getDisplayName(), autoscalePolicy.getDescription()));
+ }
+ } catch (Exception e) {
+ log.error((String.format("Unable to persist autoscaler policy
[autoscaler-policy-id] %s",
+ autoscalePolicy.getId())), e);
--- End diff --
Thanks for looking into this @Vishanth! IMO we need to raise an Autoscaler
exception if there is a problem in persisting an artifact. Would you mind
throwing an Autoscaler exception something like AutoscalerPersistenceException
from this method?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
