GitHub user chamilad opened a pull request: https://github.com/apache/stratos/pull/217
[STRATOS-1164] - PCA - Git related logic refactored to drop ambiguous library usage and enable authentication for git operations The following changes are included in this PR. 1. PCA can now clone from private git repositories 2. Redundant libraries that were used to interact with git was dropped 3. Wrote initial parametrized tests to test git cloning with several repository configurations 4. General code refactoring in git and extension related modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/chamilad/stratos git-changes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/stratos/pull/217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #217 ---- commit b24195684a9ebef3db2ff9649f5bb3e00b75f6ab Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-01-27T22:24:56Z Initial changes to Agent git logic. Dropped use of Gittle and GitPython. Adopted pexpect + git binary based approach commit b3aa77f11b57093602922986e91fc548b93dedb5 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-01-28T06:09:00Z Refactoring GitRepository class and removing gittle and gitpython references from it commit 20d7280d094983f8b887ea9e10c4205112d01483 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-01-29T08:36:54Z Refined git artifact handling Introduced git related exception Moved unncessary dependencies on outside modules to GitUtils commit ef7155081876bc55fa4e1053b55d3e2f3c329d2a Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-01-29T13:45:15Z Cleanup on agent code commit aa39a387ed3aa2bd745883583e4c5a8c61e77e47 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-03T19:53:51Z Refactored AgentGitHandler to drop dependency on CartridgeAgentConfiguration Local repository path now determined when creating the Repository object commit 29f91552a7033adbfc3da1ff145389ed7600da75 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-04T19:48:00Z Refactored Agent git clone process to include username password auth cloning Removed auth url to improve security Raised GitRepositorySynchronizationException where related Added unit test to test git clone operation commit 41d3fbdcc5475c01960d0f0a66353eab06785496 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-04T20:08:24Z Code cleanup - agentgithandler.py - Python Cartridge Agent commit d6d377ee995aefee6c332fc1e9ebdbe854487089 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-05T09:17:28Z Removed unnecessary use of pexpect commit fc5f6baaf54aecb00007a9f0fdfc064b72ea22c6 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-05T12:25:52Z Fixed unit test to convert json from unicode commit 4e8e882b225174554b5880e437b84919c45c4834 Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-06T19:16:26Z Parameterized clone test Added setup method to module scope for git tests Refactored test conf file structure Added distributable git repository details commit d4d9082914746282b65c7347deef0646924f56bb Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-06T19:30:31Z Code cleanup - PCA commit f3933726ed84c0e4e6e826a85b5f6993015a902b Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-06T19:41:11Z Refactored ExtensionHandler class Removed AbstractExtensionHandler abstraction Refactored artifact update interval reading logic commit 9d6a43e0dba615becae334e75aa66f7e8b1f0a0a Author: Chamila de Alwis <chami...@wso2.com> Date: 2015-02-06T20:27:10Z Refactored AgentGitHandler to drop circular dependency on extension handler ExtensionHandler checks if an update was done on pull calls and call update_scheduler_event accordingly ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---