Hi Devs, Find the review notes below.
Reviewed the changes as well as the following classes in general *AutoscalerService.java* - updateApplication method: comment to mention the accepted values to update - We can use void instead of returning boolean from all the methods, since the false is never returned because it throws exception - break the lengthy lines - Typos and Naming conventions - ApplicatioinPolicyNotExistsExceptions typo should be change to ApplicationPolicyNotExistsExceptions - addServiceGroup method: servicegroup should be corrected to serviceGroup - addDeployementPolicy to correct the typo - deploymentPolicyID to be changed to deploymentPolicyId - Method comments should have comment for returns - Refactor serviceGroup into cartridgeGroup - addDeploymentPolicy method: add the exceptions in the comment - removeDeploymentPolicy method: same exception is throw twice *AutoscalerServiceImpl.java* - validateAutoScalerPolicy should be changed to validateAutoscalingPolicy - Typos and Naming conventions - Convention is to use autoscalingPolicyId - validateAutoScalerPolicy method: cartridgeContexts typo - undeployApplication method: gracefull to graceful - getCartridgeContextsOfGroupsRecursively method: changing list to array, the array size was not given - getCartridgeContextsOfGroupsRecursively method: use list.addAll instead of iterating to add Regards, Vishanth On Wed, Apr 22, 2015 at 11:22 PM, Imesh Gunaratne <im...@apache.org> wrote: > Vishanth: would you mind adding the code review notes here? > > Thanks > > On Wed, Apr 22, 2015 at 10:58 AM, Reka Thirunavukkarasu <r...@wso2.com> > wrote: > >> A small correct on the time. Will have the code review at 2:30pm(IST). >> >> Thanks, >> Reka >> >> On Wed, Apr 22, 2015 at 10:45 AM, Reka Thirunavukkarasu <r...@wso2.com> >> wrote: >> >>> Hi All, >>> >>> Thought of starting with the code review today 4pm(IST) on below area. >>> Please let me know, if you all have any issues.. >>> >>> - Application deployment(addition, deployment and signup) >>> - Application Parser >>> - Nested Cartridge Groups >>> - Applications Topology and ClustersTopology >>> >>> Thanks, >>> Reka >>> >>> On Tue, Apr 21, 2015 at 10:21 AM, Reka Thirunavukkarasu <r...@wso2.com> >>> wrote: >>> >>>> Please join the discussion in >>>> https://plus.google.com/hangouts/_/hoaevent/AP36tYdHWJ48nQcVFeywwY6ZM-l2oEGR2Ri2-OIG46d9k-0DhoUWWA?authuser=0&hl=en >>>> >>>> On Mon, Apr 20, 2015 at 10:31 PM, Reka Thirunavukkarasu <r...@wso2.com> >>>> wrote: >>>> >>>>> Please find the event link as >>>>> https://plus.google.com/u/1/events/cpp77bj9v7aapl2sjb6n581eek0?authkey=CP3c5ciRw_zBOw >>>>> >>>>> >>>>> Thanks, >>>>> Reka >>>>> >>>>> On Mon, Apr 20, 2015 at 10:04 PM, Reka Thirunavukkarasu <r...@wso2.com >>>>> > wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> Will start the initial discussion tomorrow at 10am(IST). As Vishanth >>>>>> mentioned, we can keep the youtube channel for later use. >>>>>> >>>>>> Please update this thread, if this time doesn't fit... >>>>>> >>>>>> Thanks, >>>>>> Reka >>>>>> >>>>>> On Mon, Apr 20, 2015 at 9:41 PM, Lakmal Warusawithana < >>>>>> lak...@wso2.com> wrote: >>>>>> >>>>>>> +1, this is complex area and will help other devs to understand the >>>>>>> implementation. >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Reka Thirunavukkarasu >>>>>> Senior Software Engineer, >>>>>> WSO2, Inc.:http://wso2.com, >>>>>> Mobile: +94776442007 >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Reka Thirunavukkarasu >>>>> Senior Software Engineer, >>>>> WSO2, Inc.:http://wso2.com, >>>>> Mobile: +94776442007 >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Reka Thirunavukkarasu >>>> Senior Software Engineer, >>>> WSO2, Inc.:http://wso2.com, >>>> Mobile: +94776442007 >>>> >>>> >>>> >>> >>> >>> -- >>> Reka Thirunavukkarasu >>> Senior Software Engineer, >>> WSO2, Inc.:http://wso2.com, >>> Mobile: +94776442007 >>> >>> >>> >> >> >> -- >> Reka Thirunavukkarasu >> Senior Software Engineer, >> WSO2, Inc.:http://wso2.com, >> Mobile: +94776442007 >> >> >> > > > -- > Imesh Gunaratne > > Technical Lead, WSO2 > Committer & PMC Member, Apache Stratos > -- *Vishanth Balasubramaniam* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94771737718* about me: *http://about.me/vishanth <http://about.me/vishanth>*