On Fri, May 8, 2015 at 8:13 AM, Chamila De Alwis <chami...@wso2.com> wrote:

> +1
> Few notes
>
> 1. Some of Cloud Controller and Autoscaler backend errors are not returned
> as specific custom errors to the stub. Instead they are returned as
> AxisFaults. This needs to be investigated and fixed as an additional
> measure. Otherwise the change proposed would not be effective.
>

Correct. I'm working on this as well...

>  2. The CLI also doesn't properly check returned status codes when
> printing success or failure. This might also help managing those errors.
>
Will fix this as well.

Thanks.

>  On May 8, 2015 8:06 AM, "Lahiru Sandaruwan" <lahi...@wso2.com> wrote:
>
>> Hi all,
>>
>> It seems $subject is possible. We wrap real exceptions
>> with UserManagerException in this class. IMO this is not correct way of
>> handling exceptions.
>>
>> As a result of this, it returns wrong response.
>>
>> E.g. Removing non existing user returns "Could not delete user: sd", but
>> it should return that user does not exist.
>>
>> stratos>  remove-user sd
>> Could not delete user: sd
>>
>> Correct way is to let the "StratosApiV41" class handle all the specific
>> exceptions and return correct status code with message.
>>
>> Wdyt?
>>
>> Thanks.
>> --
>> --
>> Lahiru Sandaruwan
>> Committer and PMC member, Apache Stratos,
>> Senior Software Engineer,
>> WSO2 Inc., http://wso2.com
>> lean.enterprise.middleware
>>
>> phone: +94773325954
>> email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
>> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
>>
>>


-- 
--
Lahiru Sandaruwan
Committer and PMC member, Apache Stratos,
Senior Software Engineer,
WSO2 Inc., http://wso2.com
lean.enterprise.middleware

phone: +94773325954
email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146

Reply via email to