Thanks Vishanth! I have now merged this PR to master branch. On Mon, May 11, 2015 at 11:15 AM, Vishanth Balasubramaniam < vishan...@wso2.com> wrote:
> Hi Imesh, > > Followed the feedback and made the changes to the PR wherever needed. > Please merge the PR [1]. > > [1] - https://github.com/apache/stratos/pull/296 > > Thank you, > Vishanth > > On Wed, May 6, 2015 at 7:39 PM, Imesh Gunaratne <im...@apache.org> wrote: > >> Hi Vishanth, >> >> Thanks for your effort. I have added some comments in the PR, please >> review. >> >> Thanks >> >> On Wed, May 6, 2015 at 6:11 PM, Vishanth Balasubramaniam < >> vishan...@wso2.com> wrote: >> >>> Hi Devs, >>> >>> I have added the validation when adding a service group to check the >>> following >>> >>> - duplicate cartridge name in the same group level >>> - duplicate group name in the same group level >>> - cyclic behaviour of groups, i.e. when a parent group name is given >>> again in any of its sub-groups. >>> >>> Please review and merge the pull request [1]. >>> >>> [1] - https://github.com/apache/stratos/pull/296 >>> >>> Regards, >>> Vishanth >>> >>> -- >>> *Vishanth Balasubramaniam* >>> Software Engineer >>> WSO2 Inc.; http://wso2.com >>> lean.enterprise.middleware >>> >>> mobile: *+94771737718* >>> about me: *http://about.me/vishanth <http://about.me/vishanth>* >>> >>> >> >> >> -- >> Imesh Gunaratne >> >> Senior Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > > > -- > *Vishanth Balasubramaniam* > Software Engineer > WSO2 Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: *+94771737718* > about me: *http://about.me/vishanth <http://about.me/vishanth>* > > -- Imesh Gunaratne Senior Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
