Yes better to fix this type of issues in the next release, I also found
several other JSON arrays defined in singular form.

Thanks

On Mon, May 18, 2015 at 1:51 PM, Reka Thirunavukkarasu <r...@wso2.com>
wrote:

> Hi
>
> On Mon, May 18, 2015 at 1:47 PM, Lakmal Warusawithana <lak...@wso2.com>
> wrote:
>
>>
>>
>> On Mon, May 18, 2015 at 1:44 PM, Reka Thirunavukkarasu <r...@wso2.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> An update of what are the beans need to get changed with properties
>>> instead of property:
>>>
>>> - cartridge definition property section
>>> - cartridge definition IaaSProvider/property
>>> - application/property in application definition
>>> - PartitionBean
>>> - KubernetesClusterBean
>>> - KubernetesHostBean
>>> - KubernetesMasterBean
>>> - ClusterBean
>>> - MemberBean
>>>
>>> It seems that several beans are to be changed and need update in most of
>>> the samples, would it be oki to move this to next release? If so, i can
>>> create a jira and track this for next release. Please provide your thoughts.
>>>
>>
>>
>> IMO, better to do in next release. We should avoid these type of last
>> minute changes. +1 for track in JIRA
>>
> +1 to fix this in next release. Created the jira.
> https://issues.apache.org/jira/browse/STRATOS-1417
>
> Thanks,
> Reka
>
>>
>>
>>>
>>> Thanks,
>>> Reka
>>>
>>>
>>>
>>>
>>> On Mon, May 18, 2015 at 1:34 PM, Reka Thirunavukkarasu <r...@wso2.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Also, please note that application uses property. If noone is using
>>>> this property in the application at the moment, then i can change it and
>>>> update the samples.
>>>>
>>>> Thanks,
>>>> Reka
>>>>
>>>>
>>>> On Mon, May 18, 2015 at 1:10 PM, Reka Thirunavukkarasu <r...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Shaheed/Martin/Vanson,
>>>>>
>>>>> In order to keep the convention, i will have to change the cartridge
>>>>> definition bean to use properties instead of property. Do you have any
>>>>> issue with this change as it will change the cartridge definition?
>>>>>
>>>>> Thanks,
>>>>> Reka
>>>>>
>>>>> On Mon, May 18, 2015 at 1:07 PM, Anuruddha Liyanarachchi <
>>>>> anurudd...@wso2.com> wrote:
>>>>>
>>>>>> +1 for the properties.
>>>>>>
>>>>>> On Mon, May 18, 2015 at 1:05 PM, Lahiru Sandaruwan <lahi...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Yes. We need to be consistent everywhere.   +1 for properties.
>>>>>>>
>>>>>>> Thanks.
>>>>>>> On Mon, May 18, 2015 at 12:47 PM, Reka Thirunavukkarasu <
>>>>>>> r...@wso2.com> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> I saw when using propeties in the definition, we haven't used a
>>>>>>>> convention. In some definition it mentioned as ,
>>>>>>>>
>>>>>>>> properties[
>>>>>>>> {
>>>>>>>> "name" : "aaa"
>>>>>>>> "value" : "bbbbb"
>>>>>>>> }
>>>>>>>> ]
>>>>>>>>
>>>>>>>> and in some
>>>>>>>>
>>>>>>>> property[
>>>>>>>> {
>>>>>>>> "name" : "aaa"
>>>>>>>> "value" : "bbbbb"
>>>>>>>> }
>>>>>>>> ]
>>>>>>>>
>>>>>>>> IMO we should go with properties everywhere as it contains an
>>>>>>>> array. WDYT?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Reka
>>>>>>>>
>>>>>>>> --
>>>>>>>> Reka Thirunavukkarasu
>>>>>>>> Senior Software Engineer,
>>>>>>>> WSO2, Inc.:http://wso2.com,
>>>>>>>> Mobile: +94776442007
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> --
>>>>>>> Lahiru Sandaruwan
>>>>>>> Committer and PMC member, Apache Stratos,
>>>>>>> Senior Software Engineer,
>>>>>>> WSO2 Inc., http://wso2.com
>>>>>>> lean.enterprise.middleware
>>>>>>>
>>>>>>> phone: +94773325954
>>>>>>> email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
>>>>>>> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Thanks and Regards,*
>>>>>> Anuruddha Lanka Liyanarachchi
>>>>>> Software Engineer - WSO2
>>>>>> Mobile : +94 (0) 712762611
>>>>>> Tel      : +94 112 145 345
>>>>>> a <thili...@wso2.com>nurudd...@wso2.com
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Reka Thirunavukkarasu
>>>>> Senior Software Engineer,
>>>>> WSO2, Inc.:http://wso2.com,
>>>>> Mobile: +94776442007
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Reka Thirunavukkarasu
>>>> Senior Software Engineer,
>>>> WSO2, Inc.:http://wso2.com,
>>>> Mobile: +94776442007
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Reka Thirunavukkarasu
>>> Senior Software Engineer,
>>> WSO2, Inc.:http://wso2.com,
>>> Mobile: +94776442007
>>>
>>>
>>>
>>
>>
>> --
>> Lakmal Warusawithana
>> Vice President, Apache Stratos
>> Director - Cloud Architecture; WSO2 Inc.
>> Mobile : +94714289692
>> Blog : http://lakmalsview.blogspot.com/
>>
>>
>
>
> --
> Reka Thirunavukkarasu
> Senior Software Engineer,
> WSO2, Inc.:http://wso2.com,
> Mobile: +94776442007
>
>
>


-- 
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Reply via email to